fix saml login for good
Open
@butonic is already working on this.
Since Apr 20, 2018.
p3-medium
- Dominant language
- PHP
- Stars
- 17
- Forks
- 19
- Avg merge
- 11h 40m
- Merged PRs (30d)
- 2
Description
if cn or uid aru used in the saml token, the ldap app will not use them, because core currently has to use the getUsers method, which does a generic user search ... and also appends a wildcard, which is why using the email in the token is recommended to prevent ambiguous logins where more than one user matches the filter.
The proper solution in core is to introduce an api that tries to lookup a single user.
A quickfix in user_ldap would be to add the login attribute to the search filter in https://github.com/owncloud/user_ldap/blob/master/lib/User/Manager.php#L552-L556
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.