owncloud / owncloud/testing

Use Symfony/Process for executing OCC commands

Open
#15 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

technical-debt
Dominant language
PHP
Stars
4
Forks
4
Avg merge
9h 26m
Merged PRs (30d)
1

Description

Instead of needing to escape and check a lot of shell parts, for the remote OCC part we should use

https://symfony.com/doc/current/components/process.html

( Would have avoided the need for https://github.com/owncloud/testing/pull/16 )

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the code that executes remote OCC commands in this testing app, then read the Symfony Process component documentation linked in the issue. Replace the current shell-escaping and checking approach with Symfony/Process, and verify that remote OCC commands execute safely without requiring the workaround referenced by owncloud/testing#16.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, symfony
Domain
cli, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.