owncloud / owncloud/ocis

Special characters are not escaped on upload

Open
#9,704 1 comment 1 reaction 0 assignees View on GitHub
Type:Bug
Dominant language
Go
Stars
2.1k
Forks
274
Avg merge
2d 1h
Merged PRs (30d)
103

Description

## Describe the bug
When uploading, I'm allowed to upload with non UTF-8 characters. However, when I want to view / download it, I get error 500.

## Steps to reproduce
1. Use `aws s3 sync s3://my-bucket ./folder` which includes escaped names such as (`5_Pavel+Kub%C3%AD%7Fek.pdf` or `X+19-20/6_Mark%C3%A9ta+Dosoudilov%C3%A1+-+jedin%7F+v%7Fjezd+2020+(k+%7Fervnu).pdf`),
2. Upload folder into OCIS via WebUI - Folder upload,
3. Try to view the file.

## Expected behaviour
Either disallow user to upload such file or sanitise names on upload.

## Actual behaviour
File is uploaded keeping its name, however, cannot be viewed.

## Additional context
File can be renamed and it starts working then. However, name editor is acting strange when rendering non-compliant characters.

ownCloud v10 has also trouble rendering such characters, however, it allows for displaying them without issue.

OCIS:
![image](https://github.com/user-attachments/assets/d1ab8d66-4d4b-4232-aa7f-e6778eb709aa)

ownCloud 10:
![image](https://github.com/user-attachments/assets/9dc4b434-b686-4fe7-ac8b-9f6a605981c3)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.