owncloud / owncloud/ocis

Events contain Reference instead ResourceID

Open
#9,481 0 comments 0 reactions 0 assignees View on GitHub
Type:Bug
Dominant language
Go
Stars
2.1k
Forks
274
Avg merge
2d 1h
Merged PRs (30d)
103

Description

Most events in ocis contain the file reference to uniquely identify the resource. This reference contains the id of the space root and the path in the space. This is problematic. When the resource gets renamed or moved, then trying to get the resource through the old reference will fail. This is especially a problem for services like `activitylog` who need to get resource details after the move.

Fixing this is unfortunately not easy. Events are created in the eventmiddleware, where the resourceID is not available. We need to move the creation of all file related events to decomposedfs and remove them from the eventsmiddleware.

Acceptance Criteria:
* file related events are created in `decomposedfs`
* file related events are removed from the eventsmiddleware
* add the ResourceID to all file-related events. (We can still keep the reference)
* Let's not touch share or space events for now

cc @butonic

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.