owncloud / owncloud/ocis

CORS configuration too much

Open
#8,393 6 comments 1 reaction 0 assignees View on GitHub
Type:Bug
Dominant language
Go
Stars
2.1k
Forks
274
Avg merge
2d 1h
Merged PRs (30d)
103

Description

## Describe the bug
As of now some CORS parameters are configurable via env vars e.g. `OCIS_CORS_ALLOW_METHODS`, `OCIS_CORS_ALLOW_HEADERS` (and `OCIS_CORS_EXPOSE_HEADERS` - see upcoming PR by @butonic )

Besides the fact that different services require different methods and headers and need to be configured on service level - changing the working default to anything different will most probably break some services partially.

## Proposal
Do not configure allow methods, allow headers, expose headers and max ago but leave this to the individual services.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.