change tracing default to otlp
- Dominant language
- Go
- Stars
- 2.1k
- Forks
- 274
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 103
Description
jaeger [now recommends using plain otlp](https://www.jaegertracing.io/docs/1.45/apis/#opentelemetry-protocol-stable) so we should change our default config to the otlp endpoint `localhost:4317`.
For that we need to
- [x] introduce otlp traces to reva: https://github.com/cs3org/reva/pull/3496
- [x] introduce otlp traces to ocis: https://github.com/owncloud/ocis/pull/5132
to enable otlp tracing we can thens configure:
```
"OCIS_TRACING_ENABLED":"true",
"OCIS_TRACING_TYPE":"otlp",
"OCIS_TRACING_ENDPOINT":"localhost:4317", // accept OpenTelemetry Protocol (OTLP) over gRPC, if enabled
```
Then we can go further:
- [x] pass down context to get spans for aquiring file locks in decomposedfs https://github.com/cs3org/reva/pull/3809
- [ ] properly annotate server and client traces https://github.com/owncloud/ocis/pull/6471
- [x] https://github.com/owncloud/ocis/issues/5801
- [ ] annotate spans with http / grpc return codes
- [x] make traces cross services, eg. https://github.com/owncloud/ocis/issues/6350
- [x] trace uploads through datagateway https://github.com/cs3org/reva/pull/3887
- [x] https://github.com/owncloud/ocis/pull/5114
- [x] pass trace id in events
- [ ] https://github.com/owncloud/ocis/issues/4177
I recommend using signoz to check the insights and metrics that can be deduced from the traces.
Further reading: https://opentelemetry.io/docs/concepts/instrumenting-library/
Contributor guide
Assessment
This issue has not been assessed yet.