owncloud / owncloud/ocis

lico does not reuse ldap connections

Open
#5,765 0 comments 0 reactions 0 assignees View on GitHub
Type:Bug
Dominant language
Go
Stars
2.1k
Forks
274
Avg merge
2d 1h
Merged PRs (30d)
103

Description

While lico uses a system account to bind to ldap it does not reuse the ldap connection, causing to frequent Bind requests to libregraph idm, which uses argon2 to hash passwords. This can lead to OOM situations when too many reuests have to be authenticated at the same time.

While https://github.com/libregraph/lico/pull/77 is a little too eager, it shows that we can significantly reduce the number of bind requests. We should use channles as in https://github.com/cs3org/reva/blob/edge/pkg/utils/ldap/reconnect.go ... maybe move that into a separat lib that we can reuse?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.