owncloud / owncloud/ocis

not all webdav locks passing

Open
#4,999 0 comments 0 reactions 0 assignees View on GitHub
Type:Bug
Dominant language
Go
Stars
2.1k
Forks
274
Avg merge
2d 1h
Merged PRs (30d)
103

Description

```
-> running `locks':
0. init.................. pass
1. begin................. pass
2. options............... pass
3. precond............... pass
4. init_locks............ pass
5. put................... pass
6. lock_excl............. pass
7. discover.............. FAIL (compare discovered lock: owner was '4c510ada-c86b-4815-8820-42cdf82c3d51@https://cloud.ocis.test' not 'litmus test suite')
```
- [ ] we never persist the owner of the lock but always use the user in the context and construct an owner. There is a TODO to look up the displayname of the user that locked the file.

```
8. refresh............... FAIL (LOCK refresh on `/remote.php/webdav/litmus/lockme': 500 Internal Server Error)
```
- [ ] not implemented yet (in ocdav) https://github.com/cs3org/reva/blob/929383d9a0aa747a504efb27ce93d5471ee30395/internal/http/services/owncloud/ocdav/locks.go#L223-L225

👀 looking at the stuff below

```
9. notowner_modify....... WARNING: DELETE failed with 403 not 423
WARNING: MOVE failed with 403 not 423
WARNING: COPY failed with 403 not 423
WARNING: PROPPATCH failed with 403 not 423
WARNING: PUT failed with 500 not 423
...................... pass (with 5 warnings)
10. notowner_lock......... pass
11. owner_modify.......... FAIL (PUT on locked resource failed: 500 Internal Server Error)
12. notowner_modify....... WARNING: DELETE failed with 403 not 423
WARNING: MOVE failed with 403 not 423
WARNING: COPY failed with 403 not 423
WARNING: PROPPATCH failed with 403 not 423
WARNING: PUT failed with 500 not 423
...................... pass (with 5 warnings)
13. notowner_lock......... pass
14. copy.................. pass
15. cond_put.............. FAIL (PUT conditional on lock and etag failed: 500 Internal Server Error)
16. fail_cond_put......... WARNING: PUT failed with 500 not 412
...................... pass (with 1 warning)
17. cond_put_with_not..... FAIL (PUT with conditional (Not ) failed: 500 Internal Server Error)
18. cond_put_corrupt_token WARNING: PUT failed with 500 not 423
...................... pass (with 1 warning)
19. complex_cond_put...... FAIL (PUT with complex conditional failed: 500 Internal Server Error)
20. unlock................ pass
21. fail_cond_put_unlocked FAIL (conditional PUT with invalid lock-token should fail: 204 No Content)
22. lock_shared........... FAIL (requested lockscope not satisfied! got shared, wanted exclusive)
23. notowner_modify....... SKIPPED
24. notowner_lock......... SKIPPED
25. owner_modify.......... SKIPPED
26. double_sharedlock..... SKIPPED
27. notowner_modify....... SKIPPED
28. notowner_lock......... SKIPPED
29. unlock................ SKIPPED
30. prep_collection....... pass
31. lock_collection....... pass
32. owner_modify.......... pass
33. notowner_modify....... FAIL (DELETE of locked resource should fail)
34. refresh............... FAIL (LOCK refresh on `/remote.php/webdav/litmus/lockcoll/': 500 Internal Server Error)
35. indirect_refresh...... FAIL (indirect refresh LOCK on /remote.php/webdav/litmus/lockcoll/ via /remote.php/webdav/litmus/lockcoll/lockme.txt: 500 Internal Server Error)
36. unlock................ pass
37. unmapped_lock......... FAIL (LOCK on /remote.php/webdav/litmus/lockcoll/ via /remote.php/webdav/litmus/unmapped_url: 500 Internal Server Error)
38. unlock................ SKIPPED
39. finish................ pass
-> 8 tests were skipped.
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.