owncloud / owncloud/ocis

Clean Reva

Open
#10,946 4 comments 0 reactions 1 assignee Claimed by @kobergj View on GitHub
Type:Story
Dominant language
Go
Stars
2.1k
Forks
274
Avg merge
2d 1h
Merged PRs (30d)
103

Description

# Description

Note: Needs to be implemented after #10945

`owncloud/reva` was forked from `cs3org/reva` and contains a lot of code paths that are not used by ocis. We want to remove them to have less code to maintain. This requires:
- [ ] Find all imports of `owncloud/reva` in ocis
- [ ] Find all imports of `owncloud/reva` that the above packages need to work
- [ ] Find out what scripts are needed to run automated pipelines
- [ ] Delete everything else in `owncloud/reva`
- [ ] Bump `reva` in `ocis`
- [ ] Double check all ocis features are still working - consult with the team if in doubt.

## User Stories

* > As a software engineer, I want my code clean and crisp so that I don't need to look through code that I don't use.

## Value

Removing unused code will make working with reva a lot easier.

## Acceptance Criteria
- [ ] `owncloud/reva` does not contain any code that is not used/supported by `owncloud/ocis`
- [ ] `owncloud/ocis` is still working properly.

## Definition of ready
- [ ] Everybody needs to understand the value written in the user story
- [ ] Acceptance criteria have to be defined
- [ ] All dependencies of the user story need to be identified
- [ ] Feature should be seen from an end user perspective
- [ ] Story has to be estimated
- [ ] Story points need to be less than 20

## Definition of done
- Functional requirements
- [ ] Functionality described in the user story works
- [ ] Acceptance criteria are fulfilled
- Quality
- [ ] Code review happened
- [ ] CI is green (that includes new and existing automated tests)
- [ ] Critical code received unit tests by the developer
- Non-functional requirements
- [ ] No sonar cloud issues
- Configuration changes
- [ ] The next branch of the ocis charts is compatible

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.