owncloud / owncloud/ocis

fix trace disconnect

Open
#10,692 8 comments 0 reactions 0 assignees View on GitHub
Type:Bug
Dominant language
Go
Stars
2.1k
Forks
274
Avg merge
2d 2h
Merged PRs (30d)
106

Description

when analyzing trace informatien we disconnect the context in upload.go:
```go

func (store OcisStore) CreateNodeForUpload(session *OcisSession, initAttrs node.Attributes) (*node.Node, error) {
ctx, span := tracer.Start(session.Context(context.Background()), "CreateNodeForUpload")
```

this leads to the trace information for an upload not showing what is going on in CreateNodeForUpload:
![grafik](https://github.com/user-attachments/assets/e3ca25f7-9998-4f3d-bbee-02589ade3209)

What happens in these 280ms?

traces produced with https://github.com/cs3org/reva/pull/4978

Contributor guide

Open the contributing guide

Research direction

Start in upload.go at OcisStore.CreateNodeForUpload and inspect how session.Context(context.Background()) is passed to tracer.Start. Compare the upload trace with the traces from reva PR #4978 to find where the parent context is lost. Done means the work inside CreateNodeForUpload appears in the upload trace without the unexplained 280ms disconnect.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, observability-sre
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.