[FEATURE REQUEST] Remove custom NotificationHUDViewController with UNNotificationRequest
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 251
- Forks
- 142
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 3
Description
We are using a custom implementation for showing iOS system like local notifications.
Now, as we implemented iOS local notification for showing authentication errors in the file provider, we can use this framework also for in-app notifications and remove our code.
As additional benefit on M1 Silicon the notification would be shown as macOS notification.
Furthermore we should move the iOS notification permission request to a later execution time. At the moment the request will be displayed immediately after the app start. This could cause, that the user will disallow the permission.
Perfect solution would be to show a explanation view, why we need permission for that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the custom NotificationHUDViewController and the existing UNNotificationRequest implementation used for authentication errors in the file provider. Review when the iOS notification permission is currently requested and determine the flow for an explanation view before requesting it. Done means in-app notifications use the system notification framework and permission is requested later with an explanation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100