Check, if DownloadFileProgressHUDViewController is still longer needed
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 251
- Forks
- 142
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 3
Description
@felix-schwarz wrote:
On another note, looking at
DownloadFileProgressHUDViewController, I generally wonder if we still need it at all, since:
- we now have inline progress reporting/cancellation (
DownloadFileProgressHUDViewControllerpredates that)- the user can't do anything else while a file downloads for opening
Steps to reproduce
- Touch on
More Dotson a file which is currently not downloaded - Select
Open in...
Expected behaviour
Open in Sheet is displayed after download finished
Actual behaviour
UI is blocked by download progress UI
Client
iOS version:
iOS 12.2
ownCloud app version:
1.0.0. Build 113
Device model:
All
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting DownloadFileProgressHUDViewController and the More Dots > Open in flow described in the issue. Determine whether the existing inline progress and cancellation behavior makes this controller unnecessary. Done means the Open in sheet appears after the download finishes without blocking the UI with the legacy download progress view.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100