owncloud / owncloud/core

[QA] Part files are not considered for quota while they are uploaded

Open
#40,343 6 comments 0 reactions 1 assignee View on GitHub

@jvillafanez is already working on this.

Since Sep 8, 2022.

QA:team
Dominant language
PHP
Stars
8.8k
Forks
2.1k
Avg merge
20h 7m
Merged PRs (30d)
41

Description

Seen while testing https://github.com/owncloud/core/pull/39895 with 10.11.0-beta.1

The initial description for this PR has
"

  • Part files will also be considered for quota while they're being
    uploaded
    "

I believe this part of the PR was not implemented:

User2 has 40 MB quota. He has 5.4 MB already, and is uploading a 33 MB file (with chunks of 10 MB).
The used quota remains at 5.4 MB until the very last moment, when the file is assembled.

image


image


Similarly, when the uploading a 9.5 MB file (no chunking, directly into the target directory with a *.part file) the quota does not see the *.part file. Only after assembly, it jumps up.

Expected behaviour:

  • Quota used also counts part files and chunks.

Everything else in https://github.com/owncloud/core/pull/39895 seems to work fine.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.