Sharing section in settings should be removed when files_sharing is disabled
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 8.8k
- Forks
- 2.1k
- Avg merge
- 20h 7m
- Merged PRs (30d)
- 41
Description
Steps to reproduce
- Go to Apps and disable "Share Files"
- Got to settings
Expected behaviour
Sharing section on the left is removed
Actual behaviour
Sharing section is still visible
Server configuration
Operating system: Ubuntu 20.04
Web server: Apache 2.4.41-4ubuntu3.11
Database: mariadb-server 10.3.34-0ubuntu0.20.04.1
PHP version: 7.4.3-4ubuntu2.10
ownCloud version: 10.9.1
Updated from an older ownCloud or fresh install: fresh
Where did you install ownCloud from: ownCloud Ansible scripts and ownCloud Docker
Signing status (ownCloud 9.0 and above):
No errors have been found.
List of activated apps:
Enabled:
- comments:
- Version: 0.3.0
- Path: /var/www/owncloud/apps/comments
- configreport:
- Version: 0.2.0
- Path: /var/www/owncloud/apps/configreport
- dav:
- Version: 0.7.0
- Path: /var/www/owncloud/apps/dav
- federatedfilesharing:
- Version: 0.5.0
- Path: /var/www/owncloud/apps/federatedfilesharing
- federation:
- Version: 0.1.0
- Path: /var/www/owncloud/apps/federation
- files:
- Version: 1.5.2
- Path: /var/www/owncloud/apps/files
- files_external:
- Version: 0.8.0
- Path: /var/www/owncloud/apps/files_external
- files_mediaviewer:
- Version: 1.0.5
- Path: /var/www/owncloud/apps/files_mediaviewer
- files_trashbin:
- Version: 0.9.1
- Path: /var/www/owncloud/apps/files_trashbin
- files_versions:
- Version: 1.3.0
- Path: /var/www/owncloud/apps/files_versions
- firstrunwizard:
- Version: 1.2.0
- Path: /var/www/owncloud/apps/firstrunwizard
- market:
- Version: 0.6.3
- Path: /var/www/owncloud/custom/market
- notifications:
- Version: 0.5.4
- Path: /var/www/owncloud/apps/notifications
- openidconnect:
- Version: 2.1.1
- Path: /var/www/owncloud/custom/openidconnect
- password_policy:
- Version: 2.1.4
- Path: /var/www/owncloud/custom/password_policy
- provisioning_api:
- Version: 0.5.0
- Path: /var/www/owncloud/apps/provisioning_api
- systemtags:
- Version: 0.3.0
- Path: /var/www/owncloud/apps/systemtags
- twofactor_totp:
- Version: 0.7.4
- Path: /var/www/owncloud/custom/twofactor_totp
- updatenotification:
- Version: 0.2.1
- Path: /var/www/owncloud/apps/updatenotification
- user_ldap:
- Version: 0.16.0
- Path: /var/www/owncloud/custom/user_ldap
Disabled:
- encryption:
- Path: /var/www/owncloud/apps/encryption
- external:
- Path: /var/www/owncloud/apps/external
- files_sharing:
- Path: /var/www/owncloud/apps/files_sharing
- user_external:
- Path: /var/www/owncloud/apps/user_external
- windows_network_drive:
- Path: /var/www/owncloud/custom/windows_network_drive
Are you using encryption: no
Are you using an external user-backend, if yes which one: Behaviour is independent of the backend, I also tested another system with another user-backend
Client configuration
Browser: Safari
Operating system: MacOS Monterey 12.4 (21F79)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the settings navigation shown after disabling files_sharing through Apps → Share Files, using the settings page as the entry point. Confirm that the Sharing section is absent while files_sharing is disabled and returns when the app is re-enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100