Enabling/Disabling `shareapi_auto_accept_share` while receiving the requested share results in different behavior
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 8.8k
- Forks
- 2.1k
- Avg merge
- 20h 7m
- Merged PRs (30d)
- 41
Description
Description
While sharing the same file/folder in different ways by one user [group and user] and receiving the requested share by enabling/disabling the shareapi_auto_accept_share by another user results in different behavior
Steps to reproduce
When the shareapi_auto_accept_share is enabled:
- Create a group
developersand a userdemo - Add user
demoto groupdevelopers admincreates a folderparentFoderadminshares the folderparentFolderwith groupdevelopers- Then the user
demoreceives the folder and renames it asreceivedParentFolder - Now, the
adminshares the folderparentFolderwith userdemo
As userdemothe folderreceivedParentFolderexists and the folderparentFolderfrom the last share doesn't exist.
When the shareapi_auto_accept_share is disabled:
- Create a group
developersand a userdemo - Add user
demoto groupdevelopers admincreates a folderparentFoderadminshares the folderparentFolderwith groupdevelopers- Then the user
demoaccepts the share request from admin - And the user
demorenames the folder asreceivedParentFolder - Now, the
adminshares the folderparentFolderwith userdemo - Again, the user
demoaccepts the share request from admin
As userdemothe folderparentFolderexists and folderreceivedParentFolderdisappears.
The test is automated and is reproduced manually too.
might be related to this issue #39347
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue provides no file or test path; start by locating the automated reproduction for shareapi_auto_accept_share and run it with the setting enabled and disabled. Trace the group-share and direct-user-share acceptance flows, then add or update a regression test covering the rename and subsequent share behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100