owncloud / owncloud/core

Enabling/Disabling `shareapi_auto_accept_share` while receiving the requested share results in different behavior

Open
#39,959 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type:Bug
Dominant language
PHP
Stars
8.8k
Forks
2.1k
Avg merge
20h 7m
Merged PRs (30d)
41

Description

Description

While sharing the same file/folder in different ways by one user [group and user] and receiving the requested share by enabling/disabling the shareapi_auto_accept_share by another user results in different behavior

Steps to reproduce

When the shareapi_auto_accept_share is enabled:

  1. Create a group developers and a user demo
  2. Add user demo to group developers
  3. admin creates a folder parentFoder
  4. admin shares the folder parentFolder with group developers
  5. Then the user demo receives the folder and renames it as receivedParentFolder
  6. Now, the admin shares the folder parentFolder with user demo
    As user demo the folder receivedParentFolder exists and the folder parentFolder from the last share doesn't exist.

When the shareapi_auto_accept_share is disabled:

  1. Create a group developers and a user demo
  2. Add user demo to group developers
  3. admin creates a folder parentFoder
  4. admin shares the folder parentFolder with group developers
  5. Then the user demo accepts the share request from admin
  6. And the user demo renames the folder as receivedParentFolder
  7. Now, the admin shares the folder parentFolder with user demo
  8. Again, the user demo accepts the share request from admin
    As user demo the folder parentFolder exists and folder receivedParentFolder disappears.

The test is automated and is reproduced manually too.

might be related to this issue #39347

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue provides no file or test path; start by locating the automated reproduction for shareapi_auto_accept_share and run it with the setting enabled and disabled. Trace the group-share and direct-user-share acceptance flows, then add or update a regression test covering the rename and subsequent share behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.