owncloud / owncloud/core

Current author is not shown when file_storage.save_version_author is set

Open
#39,680 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement QA:team
Dominant language
PHP
Stars
8.8k
Forks
2.1k
Avg merge
20h 7m
Merged PRs (30d)
41

Description

Seen in 10.9.1 RC2 with
occ config:system:set file_storage.save_version_author --type boolean --value true

  • admin adds a 'New text file.txt' and does several edits with files_texteditor
  • admin opens the details sidebar and inspects the versions.
  • For all versions except for the current version, the author name is shown:
    image

Expected behaviour:

  • Near the top, under the filename, the line < 1 KB, seconds ago should say e.g. < 1KB, seconds ago, admin

This feature is only important in a shared scenario. When multiple users edit a file, they can see who did the second last change (and before), but they cannot see who did the very last change.

Workaround: one user commits a dummy edit, so that the change in question is listed under Versions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with occ config:system:set file_storage.save_version_author --type boolean --value true, then inspect the details sidebar and Versions behavior in files_texteditor. Done means the current version shows its author near the filename, consistently with older versions, with a regression test covering the display.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
full-stack
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.