owncloud / owncloud/core

Trashcan restore restores silently to home, if original subfolder is missing

Open
#39,551 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement QA:team
Dominant language
PHP
Stars
8.8k
Forks
2.1k
Avg merge
20h 7m
Merged PRs (30d)
41

Description

Seen in 10.9.0 beta1

  • have an external SFTP storage
  • create a subdirectory SFTP/xxx
  • create a file 'SFTP/xxx/Untitiled 1.odt' (using a desktop client)
  • delete the folder 'SFTP/xxx'
  • via web browser, visit the trashcan, click into xxx, and restore 'Untitled 1.odt' (without restoring xxx)
  • The file 'Untitled 1.odt' appears in the users home. Not in the external storage. BAD.
  • The file is also restored to home, if the the xxx folder was recreated manually inside SFTP.

Expected behavior:

  • autocreate the xxx folder.
  • (or at least) give a prominent message to the user, that his file is now elsewhere.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the trashcan restore flow described in the issue and trace how a deleted file records and resolves its original SFTP path when the parent folder is missing. Reproduce the steps with external SFTP storage, then verify that restoring the file recreates the missing subfolder or gives a prominent relocation message instead of silently placing it in the user's home.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.