[QA] moving a folder containing a received share into another received share breaks apart
Open
Nobody has claimed this yet.
Type:Bug
- Dominant language
- PHP
- Stars
- 8.8k
- Forks
- 2.1k
- Avg merge
- 20h 7m
- Merged PRs (30d)
- 41
Description
Seen with oc 10.8.0-beta2 while testing https://github.com/owncloud/core/pull/38767
- admin creates "folder1/path/to/file.txt" and "folder2/pot/too/fool.txt"
- admins shares "folder1" and "folder2" with user1.
- user1 moves "folder2" (shared) into "folder1 (shared)"
- Move is prevented and no file scan happens. -> The move is expected to fail. The proper error message appears:
Could not move "folder2": There was an error while renaming the file or directory - user1 also has a (not shared) folder Documents. user1 moves folder2 into Documents,
- user1 moves Documents into folder1. -> No error message appears. BAD
- the user interface indicates that the entire hierarchy of Documents was moved into folder1, this is not true. BAD
- in reality (seen after a shift reload) user1 can see, that folder2 appears on toplevel, (next to folder1) while Documents was indeed moved into folder1
Expected behaviour:
- The same error message appears, as if directly trying to move folder2 into folder1
- the UI indicates shows the resulting folder structure immediately (no need for shift reload)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the listed move sequence on ownCloud 10.8.0-beta2 and review the move-related changes in pull request 38767. Done means the same error appears when the nested received share is moved, and the UI immediately shows the actual resulting folder structure without a reload.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- backend, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100