owncloud / owncloud/core

[QA] Update needed in Web-UI is misleading

Open
#38,485 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

QA:team
Dominant language
PHP
Stars
8.8k
Forks
2.1k
Avg merge
20h 7m
Merged PRs (30d)
41

Description

Seen while installing files_pdfviewer-0.12.0RC1 in docker owncloud/server:10.5 (and also docker owncloud/server:10.6.0)

image

The message is misleading. pdfviewer is not asking for an upgrade of 10.5.0 to a later core version -- it actually wants to
run database migrations, as installing files_pdfviewer-0.12.0 is actually an update from the shipped files_pdfviewer-0.11.0

Our docker images apparently ship with a config.php setting that not only prevent 'automatic' updates but also hides important information from the web UI.

In a manually installed 10.6 instance config.php is without the 'upgrade.disable-web' entry and we get the needed details:
image

Expected behaviour: 'upgrade.disable-web' => true only removes the 'Start Update' button, but leaves the text as is.

@iHerrmann77 thanks for spotting.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the docker image config.php setting for 'upgrade.disable-web' with the manually installed configuration and trace where that setting affects the Web-UI update message. Verify that disabling the button does not remove the migration details, using the reported pdfviewer installation scenario as the completion check.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.