owncloud / owncloud/core

Sharing without change permission should not show a rename button

Open
#35,758 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

QA:team
Dominant language
PHP
Stars
8.8k
Forks
2.1k
Avg merge
20h 7m
Merged PRs (30d)
41

Description

Testing web UI of 10.2.1RC3

User admin shares folder AdminPhotos with user jwtest with share, create, delete permissions, but without change permission:

image

User jwtest does not see a rename button on files within AdminPhotos (no change permisision, ok). But user jwtest has a rename button on subfolders within AdminPhotos.

image

Actually trying a rename results in an error then.
This is inconsistent. Either always have the rename button and show errors, or never have the rename button.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the web UI case with share, create, and delete permissions but without change permission, then trace where the rename button is shown for files versus subfolders. Compare the button’s visibility with the rename request’s permission handling; done means subfolders no longer expose an unusable rename action and the behavior is covered consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
authorization, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.