owncloud / owncloud/core

Acceptance tests for sharing when the receiver has a matching file/folder

Open
#35,414 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

dev:acceptance-tests QA:p3 QA:team
Dominant language
PHP
Stars
8.8k
Forks
2.1k
Avg merge
20h 7m
Merged PRs (30d)
41

Description

Background

Currently the sharing acceptance tests mostly use files and folders that are in the "standard" acceptance test webUI or API skeleton. e.g. user1 and user2 both have simple-folder. When user1 shares simple-folder with user2 then user2 receives a folder called simple-folder (2). So we have "accidentally" created lots of test scenarios for the case where the share receiver already has a matching file or folder name.

As part of speeding up CI, we are reducing the use of the "standard" skeleton (it takes significant time to create for every user of every scenario). Scenarios will (soon) usually result in the share receiver not already having a matching file or folder. So the (2) naming thing will not get tested much.

To Do

Create explicit test scenarios for sharing where the share receiver already has a matching file or folder name.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the existing sharing acceptance scenarios and the completed checklist items in this issue to understand the established coverage for matching names. Add the remaining scenario for a matching file shared before the receiver logs in, and verify the receiver's resulting file and skeleton behavior; document any additional scenario ideas only if they are concrete.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.