Acceptance tests for sharing when the receiver has a matching file/folder
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 8.8k
- Forks
- 2.1k
- Avg merge
- 20h 7m
- Merged PRs (30d)
- 41
Description
Background
Currently the sharing acceptance tests mostly use files and folders that are in the "standard" acceptance test webUI or API skeleton. e.g. user1 and user2 both have simple-folder. When user1 shares simple-folder with user2 then user2 receives a folder called simple-folder (2). So we have "accidentally" created lots of test scenarios for the case where the share receiver already has a matching file or folder name.
As part of speeding up CI, we are reducing the use of the "standard" skeleton (it takes significant time to create for every user of every scenario). Scenarios will (soon) usually result in the share receiver not already having a matching file or folder. So the (2) naming thing will not get tested much.
To Do
Create explicit test scenarios for sharing where the share receiver already has a matching file or folder name.
- share with user, receiver has a matching folder https://github.com/owncloud/core/pull/36451
- share with user, receiver has a matching file https://github.com/owncloud/core/pull/35455
- share with group, receiver has a matching folder https://github.com/owncloud/core/pull/36451
- share with group, receiver has a matching file https://github.com/owncloud/core/pull/36451
- share with federated, receiver has a matching folder (https://github.com/owncloud/core/pull/35453)
- share with federated, receiver has a matching file https://github.com/owncloud/core/pull/35453
- with and without auto-accept of shares https://github.com/owncloud/core/pull/36451
- shares received from multiple users with the same name file/folder https://github.com/owncloud/core/pull/35457
- shares received from multiple users with the same name file/folder and different permissions (check that the different permissions work on the correct shares) https://github.com/owncloud/core/pull/35457
- matching file is shared with a user before that user has logged in (what happens when the user logs in and gets a matching file in their skeleton...)
- matching folder is shared with a user before that user has logged in (what happens when the user logs in and gets a matching folder in their skeleton...) https://github.com/owncloud/core/pull/36451
- new user is created and added to a group. The group has shares that match the skeleton. What happens when the user logs in? https://github.com/owncloud/core/pull/35457
- write more ideas for scenarios here...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the existing sharing acceptance scenarios and the completed checklist items in this issue to understand the established coverage for matching names. Add the remaining scenario for a matching file shared before the receiver logs in, and verify the receiver's resulting file and skeleton behavior; document any additional scenario ideas only if they are concrete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100