[FEATURE REQUEST] Sharing NG: edit share
- Dominant language
- Kotlin
- Stars
- 4.2k
- Forks
- 3.1k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 7
Description
Edit an existing share with a user or group adding a pencil button in each share
Permission: libre.graph/driveItem/permissions/update
By clicking the pencil icon, same view as Create is displayed, with the existing permission selected and the expiration date.
Both permission and expiration date could be changed:
- Permission is mandatory, so, it's not allowed to be empty
- Expiration date could be emptied
Request
PATCH https://<url>/graph/v1beta1/drives/<drive-id>/items/<item-id>/permissions/<share-id>
with body:
{
"roles": [
"b1e2218d-eef8-4d4c-b82d-0f1a1b48f3b5"
],
"expirationDateTime": "2026-07-29T12:57:30.830Z"
}
if only one of the fields changed, that field included. If expirationDateTime was removed, add null value
share-id is returned when the share is created, and also fetched in the list of shares.
Custom spaces
only Managers are allowed to
It could be findings regarding refactors of existing code for space management. Add to the https://github.com/owncloud/android/issues/4949 issue.
TASKS
- Research (if needed)
- Create branch feature/edit_file_share
- Development tasks
- Show pencil icon when user has permission
- Display edit screen with member and role binding
- Implement methods and network operation
- Implement unit tests (if needed)
- Code review and apply changes requested
- Design test plan
- QA
- Merge branch feature/edit_file_share into master
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.