[BUG] Lack of message when locked image file is removed from preview
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 4.2k
- Forks
- 3.1k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 7
Description
This one comes from https://github.com/owncloud/android/pull/4285#issuecomment-1908115473
Steps to reproduce
- Lock a picture file
- Open the picture in the app to preview it
- Remove the picture from the preview
Actual behaviour
Nothing happens
Expected behaviour
An snackbar clarifying that the file could not be removed because it's locked
In the following video, the file land1.jpg is locked. Removing from preview does not give feedback, removing from file list gives feedback:
https://github.com/owncloud/android/assets/14894746/ea5542be-d3be-4857-89fa-f8956fdd09d1
How to lock a file:
- Try to remove a video that is being streamed from server (not a local copy)
- In oC10 servers: Log in an admin account > Settings (top right menu) > General (left menu, admin side) > tick
Enable manual file locking in the web interface. Once enabled, every file (not folder) in the list will have an optionLock fileavailable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the locked-file removal flow from the preview and compare it with removal from the file list, which already provides feedback. Trace the preview removal entry point and its error handling; done means a snackbar clearly explains that a locked file could not be removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100