owncloud / owncloud/android

[SPACES] Sharing with spaces

Open
#3,917 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature request Spaces
Dominant language
Kotlin
Stars
4.2k
Forks
3.1k
Avg merge
1d 12h
Merged PRs (30d)
7

Description

Shares is a separate space in the new oCIS server. All accepted shares will go to such space instead of Personal.

Accepted shares with the following values in the drives/me endpoint

"driveAlias" : "mountpoint/<name>",
"driveType" : "mountpoint",

But also, the existing sharing API could be used to fetch shares (deprecated in the future?)

As the web, we should include three sections:

  • Shared with me
  • Shared by me
  • Shared by link

how to set them in the view?

  • Different sections in the same view, in vertical mode.
  • Tabs (like web)
  • other...

Shared by me items have up to 3 statuses:

  • Pending: other user shares with me, and i'm pending to accept or decline (state = 1)
  • Accepted: accepted from pending or declined (state = 0)
  • Declined: declined from pending, or unshared from accepted (state = 2)

To accept a pending/declined share (sharing API)

POST https://<url>/ocs/v2.php/apps/files_sharing/api/v1/shares/pending/<share_id>

share_id also in the payload

To decline an accepted/pending share (sharing API)

DELETE https://<url>/ocs/v2.php/apps/files_sharing/api/v1/shares/pending/<share_id>

share_id also in the payload

Discussion: all these changes should be applied also to oC10? since API is common in some points to legacy one.

TASKS
  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master
PR
  • App
  • Library (if needed)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files, tests, or entry points are named. Start by reviewing the existing sharing API, including the listed pending-share POST and DELETE endpoints, and the Android sharing view. Done would require an agreed layout for the three sections, support for the stated share statuses and actions, and a defined decision about oC10 compatibility.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.