[FEATURE REQUEST] Hide "Sharing" option if API is disabled and privateLinks false
Open
Nobody has claimed this yet.
Feature request
- Dominant language
- Kotlin
- Stars
- 4.2k
- Forks
- 3.1k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 7
Description
from https://github.com/owncloud/android/pull/3738#issuecomment-1229879710
- In server admin dashboard, open Admin -> Sharing
- Disable
Allow apps to use the Share API
in that case, Share API is not available and users will not be allowed to shares with users or by link. But, the "Share" option is still available because the private link.
I mean, if:
- Share API is disabled
privateLinks: false
the sharing option in top bar could be disabled as well.
Tested with samsung A51 Android12
TASKS
- Research (if needed)
- Create branch feature/feature_name
- Development tasks
- Implement whatever
- ...
- Code review and apply changes requested
- Design test plan
- QA
- Merge branch feature/feature_name into master
PR
- App
- Library (if needed)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the top-bar Share option and how it reads the Share API and privateLinks settings; the issue provides no file or test names. Done means the sharing option is unavailable when both Share API is disabled and privateLinks is false, with the behavior verified through the requested test plan.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100