Improved message for disabled users
Open
Nobody has claimed this yet.
Authentication
- Dominant language
- Kotlin
- Stars
- 4.2k
- Forks
- 3.1k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 7
Description
- Go to server user dashboard
- Disable user
- In Android app, login with the disabled user
Current:
Wrong username or password as error message
Expected: a more accurate message could be used, since the response contains it:
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
<s:exception>Sabre\DAV\Exception\NotAuthenticated</s:exception>
<s:message>User disabled</s:message>
</d:error>
OAuth2 app & web show the User disabled message
TASKS
- Research (if needed)
- Create branch feature/feature_name
- Development tasks
- Implement whatever
- ...
- Code review and apply changes requested
- Design test plan
- QA
- Merge branch feature/feature_name into master
PR
- App
- Library (if needed)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named; start by tracing the Android app's login handling for a disabled user and compare it with the OAuth2 app and web behavior. Reproduce the dashboard-disable and login steps, then verify that the response's “User disabled” message is shown instead of “Wrong username or password.”
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100