owncloud / owncloud/android

Warn users when redirection happens

Open
#3,131 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature request p3-medium
Dominant language
Kotlin
Stars
4.2k
Forks
3.1k
Avg merge
1d 12h
Merged PRs (30d)
7

Description

This comes from: https://github.com/owncloud/android/pull/3074#issuecomment-789682250

If a redirection happens, user must be notified and approve explicitly the issue (a similar way to do as in a self-signed certificate)

iOS example:

Screenshot 2021-03-03 at 13 12 17

AC:

  • When the URL is checked, if a redirection happens, a dialog/alert/whatever is displayed to notify the issue
  • When the user accepts, auth flow goes on
  • In case the user does not accept the redirection, the auth flow stops

NOTE: this is the same way to do as in a self-signed/not secured server certificate

TASKS
  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Create new exception when redirection 301 or 302 happens
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master
PR
  • App
  • Library (if needed)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests; start by tracing URL checking and the authentication flow, then compare the existing self-signed or unsecured certificate handling. Done means a 301 or 302 redirect shows an approval prompt, continues authentication after acceptance, and stops the flow when declined.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
authentication, mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.