Don't rely on phpunit/php exit code in CI
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 16
- Forks
- 16
- Avg merge
- 11h 11m
- Merged PRs (30d)
- 1
Description
We have had some times in the past when there have been errors/failures reported in a phpunit test run, but phpunit exits with status 0.
I have not noticed it with phpunit7 (that is used since core 10.4.0) but have not been looking hard either!
Consider the comments in issue #550 - maybe add some code in CI that parses the output of phpunit and will make the test run fail if "bad stuff happened". https://github.com/owncloud/QA/issues/550#issuecomment-510448891
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the existing CI invocation of phpunit and the referenced comment in issue #550. The work is done when CI detects reported errors or failures even if phpunit exits with status 0, and marks the test run as failed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, shell
- Domain
- ci-cd, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100