owlcollab / owlcollab/owltools
SolrCommandRunner should skip models that are unsatisfiable
Open
@yy20716 is already working on this.
Since Feb 10, 2018.
- Dominant language
- Java
- Stars
- 115
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
Testing the loader, we now fail with:
2018-01-18 00:14:59,213 INFO (ParserWrapper:82) Finished loading ontology: http://model.geneontology.org/0000000300000001 from: file:/home/bbop/local/src/git/noctua-models/models/0000000300000001.ttl
2018-01-18 00:15:45,210 ERROR (SolrCommandRunner:609) Unsatisfiable: 0000000300000001.ttl == [<http://purl.obolibrary.org/obo/EMAPA_36026>, <http://purl.obolibrary.org/obo/EMAPA_25090>, <http://purl.obolibrary.org/obo/EMAPA_16777>, <http://purl.obolibrary.org/obo/EMAPA_16133>,
...
This is understandable as (IIRC) it is part of a set of mock-up models--I doubt anything sensible would be loaded even it was satisfiable. I think the best course of action would be to continue on with other models if any single model unsatisfiable. I would like to have something in there soon for demo purposes and this would be the fastest way forward.
Hopefully I'll be able to supply a PR soon...
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.