owlcollab / owlcollab/owltools
Solr loading should be resilient in the face of unknown taxon IDs
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 115
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
E.g. when loading cgd we get
2017-05-01 10:16:25,974 INFO (GafSolrDocumentLoader:189) Skipping taxon closures for unknown id: NCBITaxon:1136231
2017-05-01 10:16:25,980 INFO (GafSolrDocumentLoader:189) Skipping taxon closures for unknown id: NCBITaxon:1136231
2017-05-01 10:16:25,984 INFO (GafSolrDocumentLoader:189) Skipping taxon closures for unknown id: NCBITaxon:1136231
First, this should not be INFO, it should be WARN or ERROR. Second, no need to repeat. It should collect all issues and report at the end.
Last, we need to check that at least reflexive singleton closure is produced
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with GafSolrDocumentLoader around line 189 and reproduce the cgd loading case that reports unknown taxon IDs. Check that repeated unknown IDs are collected and reported once at WARN or ERROR level, and verify that each has a reflexive singleton closure. Add or run the relevant loader tests if they are present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100