owasp-modsecurity / owasp-modsecurity/ModSecurity

sanitiseMatchedBytes only works with 1 digit parameters

Open
#2,472 5 comments 0 reactions 1 assignee View on GitHub

@zimmerle is already working on this.

Since Dec 9, 2020.

2.x enhancement
Dominant language
C++
Stars
9.8k
Forks
1.8k
Avg merge
2h 46m
Merged PRs (30d)
1

Description

sanitiseMatchedBytes:5/8 => OK
sanitiseMatchedBytes:10/2 => not accepted => sanitizes the whole string

In msre_action_sanitizeMatchedBytes_init():
if (action->param != NULL && strlen(action->param) == 3)
should be
if (action->param != NULL && strlen(action->param) >= 3)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.