owasp-modsecurity / owasp-modsecurity/ModSecurity-nginx

NGINX has to be restarted after sys internal log rotation feature

Open
#351 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

duplicate
Dominant language
Perl
Stars
1.9k
Forks
312
PR merge metrics
No merged PRs in 30d

Description

Hello,

I have noticed that if you use the build-in log rotation of Linux

Reference:

[akama.aka@dc-eu-ger-fra-001 ~]$ cat /etc/logrotate.conf 
# see "man logrotate" for details

# global options do not affect preceding include directives

# rotate log files weekly
weekly

# keep 4 weeks worth of backlogs
rotate 4

# create new (empty) log files after rotating old ones
create

# use date as a suffix of the rotated file
dateext

# uncomment this if you want your log files compressed
#compress

# packages drop log rotation information into this directory
include /etc/logrotate.d

# system-specific logs may be also be configured here.


/var/log/modsec_audit.log {
	compress
	daily
	missingok
	rotate 366
}

that the nginx server must be restarted so that it continues to be logged into the /var/log/modsec_audit.log file. Otherwise everything remains empty and it is written to the nginx own error log file.

I've created a crontab that restarts the nginx Server one minute after 12am.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin by reproducing rotation with /etc/logrotate.conf and /var/log/modsec_audit.log, then trace how the NGINX connector handles the rotated file and error-log fallback. Done means log rotation continues writing audit entries to the expected file without the reported restart workaround; no test file is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
linux, nginx
Domain
devops, observability-sre
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.