owasp-modsecurity / owasp-modsecurity/ModSecurity-nginx

Add an Option to Log Proxied Client IPs

Open
#341 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Perl
Stars
1.9k
Forks
312
PR merge metrics
No merged PRs in 30d

Description

When using the Proxy Protocol, the ModSecurity module isn't currently able to access the client's IP. Thus, only the proxying server's IP is available.

For a project I work on, we needed an option to do so and implemented a patch we would like to upstream. Could I open a PR for it?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the ModSecurity-nginx connector handles Proxy Protocol requests and exposes the client address to ModSecurity. Reproduce a proxied request, define how the logging option should behave, and add coverage showing that the client IP is logged instead of only the proxy address.

Written by the indexing model from the issue text.

Assessment

Tech stack
nginx
Domain
backend, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.