overengineeringstudio / overengineeringstudio/effect-utils

restore green check:quick baseline for notion-react workspace tasks

Open
#605 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

origin:agent type:chore
Dominant language
TypeScript
Stars
82
Forks
2
Avg merge
1d 8h
Merged PRs (30d)
121

Description

Context

  • While validating the notion-react demo coverage work on branch schickling/2026-04-19-notion-react, repo quality gates were not clean before or after the demo changes.
  • The new demo files pass targeted oxfmt, targeted oxlint, package unit tests, and Storybook build.
  • Repo-wide ts:check / lint:check still fail on unrelated files.

Current failures

  • ts:check fails in packages/@overeng/notion-react/src/renderer/sync-mock.unit.test.tsx because session fixtures no longer satisfy the Session type (id, title, body missing)
  • lint:check reports existing warnings in packages/@overeng/notion-effect-client/src/blocks.ts (missing export JSDoc) and packages/@overeng/notion-react/src/renderer/sync-metrics.shape.unit.test.tsx (no-map-spread)

Follow-up

  • restore a green devenv tasks run ts:check --mode before baseline
  • restore a green devenv tasks run lint:check --mode before baseline
  • keep the notion-react public demo work separate from these unrelated cleanup changes

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/@overeng/notion-react/src/renderer/sync-mock.unit.test.tsx and update the session fixtures to satisfy the reported Session type failure. Then inspect the warnings in packages/@overeng/notion-effect-client/src/blocks.ts and packages/@overeng/notion-react/src/renderer/sync-metrics.shape.unit.test.tsx. Run devenv tasks run ts:check --mode before and devenv tasks run lint:check --mode before; done means both checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.