overengineeringstudio / overengineeringstudio/effect-utils

Clean up @overeng/notion-react lint exemptions before GA

Open
#599 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:typescript origin:agent type:chore
Dominant language
TypeScript
Stars
82
Forks
2
Avg merge
1d 8h
Merged PRs (30d)
121

Description

The root .oxlintrc.json contains a **/notion-react/** overrides block that disables several rules as an incubation-period waiver, applied in #584 to get CI green without a large cleanup diff. These exemptions should be removed (and the underlying issues fixed) before @overeng/notion-react graduates to GA.

Exempted rules

All of the following are disabled for **/notion-react/** only:

Rule Warnings at exemption time
overeng/jsdoc-require-exports 127
overeng/explicit-boolean-compare 52
overeng/named-args 47
overeng/exports-first 33
overeng/storybook/csf-component 24
no-await-in-loop 1 (unit test)

Total ~284 findings waived.

Before GA

  • Remove the **/notion-react/** overrides block from .oxlintrc.json.
  • Run oxlint --deny-warnings and fix the remaining issues (or justify per-file overrides).
  • Ensure lint:check:oxlint passes without the waiver.

Ref: #584

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the root .oxlintrc.json and inspect the /notion-react/ overrides block. Run oxlint --deny-warnings, then work through the reported findings in @overeng/notion-react, using per-file overrides only where justified. Done means the waiver is removed and lint:check:oxlint passes without it.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.