overengineeringstudio / overengineeringstudio/effect-utils
TUI Storybook preview pattern still triggers CSF parsing warnings
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 82
- Forks
- 2
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 121
Description
Problem
The shared TUI Storybook setup in effect-utils still emits CSF parsing warnings during storybook dev --ci --smoke-test.
I reproduced this in at least:
packages/@overeng/megarepopackages/@overeng/notion-cli
Both currently use the shared helper in .storybook/main.ts, but their .storybook/preview.tsx uses:
import { tuiPreview } from "@overeng/tui-react/storybook"
export default tuiPreview
That produces warnings like:
CSF Parsing error: Expected "ObjectExpression" but found "Identifier"
Repro
From one of the TUI packages above:
./node_modules/.bin/storybook dev --ci --smoke-test --port 6200
Expected
The shared TUI Storybook pattern should be warning-free under Storybook's CSF parser so downstream repos can fail CI/lint on these warnings.
Notes
createTuiStorybookConfigitself appears fine and should stay the source of truth.- The local OpenTUI stub should continue to live in
@overeng/utils; downstream repos should not need their own copy. - In downstream validation, switching the preview default export to a literal object fixed the warning:
import type { Preview } from "@storybook/react"
import { tuiPreview } from "@overeng/tui-react/storybook"
export default {
...tuiPreview,
} satisfies Preview
A good follow-up would be to standardize that pattern in effect-utils and, if useful, add a shared smoke check so the warning stays covered.
Opened by Codex on behalf of @schickling.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the shared Storybook setup in effect-utils and the .storybook/main.ts and .storybook/preview.tsx files in packages/@overeng/megarepo and packages/@overeng/notion-cli. Run ./node_modules/.bin/storybook dev --ci --smoke-test --port 6200 in one of those packages, then verify the shared pattern completes without CSF parsing warnings while keeping createTuiStorybookConfig and the @overeng/utils stub unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100