Company names are not validated
@asraa is already working on this.
Since Jun 15, 2021.
- Dominant language
- Go
- Stars
- 5.7k
- Forks
- 724
- Avg merge
- 19h 30m
- Merged PRs (30d)
- 1
Description
In the Collaborators check, we fetch the names of companies the user belongs to.
These names can be set by users arbitrarily. If scorecard users take into account the company of contributors to make decisions, these names should be verified.
We may use the list-org API instead.
Another problem is that we currently do not check how many companies a user belongs to. A contributor (we currently enforce >5 commits) can set any number of companies they want and it will pass the test. We're not enforcing a single company per user. (Is this an invariant we can enforce?)
A limitation of this check is that organization should update when users leave.
It's pretty easy to typo-squat orgs too, see https://github.com/GoogleContainerTooIs vs https://github.com/GoogleContainerTools.
So we should always verify the org is 'verified', like https://github.com/google
One limitation of the 'verified' org is that it seems to verify the domain ownership, but there is no enforcement about the org name itself.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.