oss-slu / oss-slu/PilotDataSynchronization

YawSync XML range does not match either angular convention used elsewhere

Open
#186 0 comments 0 reactions 1 assignee View on GitHub

@Phlabry is already working on this.

Since Sep 17, 2026.

bug rust
Dominant language
Rust
Stars
4
Forks
8
Avg merge
5d 17h
Merged PRs (30d)
2

Description

Describe the bug
create_xml_file uses two self-consistent angular conventions: signed symmetric for Roll and Pitch (-180/180) and unsigned compass for Heading (0/360). YawSync is -180/360 (relay/src/update.rs:262-263), which matches neither and spans 540 degrees.

Expected behavior
Yaw uses the unsigned compass convention, 0/360. Yaw comes from sim/flightmodel/position/psi (xplane_plugin/src/pilotdatasync-xp11.cpp:212), which is X-Plane's true heading, not a signed angle like phi and theta. In the committed flight data (inference/Data/labeled_flight_data.csv, 16,604 rows) yaw ranges from 0.55 to 359.96 and is never negative. An earlier version of this issue suggested -180/180, which would put half of the real values out of range.

Additional context
Full inventory: Altitude 0/50000, Airspeed 0/600, VerticalVelocity -5000/5000, Heading 0/360, Roll -180/180, Pitch -180/180, Yaw -180/360, GForce -10/10. Worth confirming against iMotions before changing, since the range affects graph scaling.

Found while writing the setup documentation in #138 / #178.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.