oss-slu / oss-slu/PilotDataSynchronization
event_log is written throughout the relay but never displayed
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 4
- Forks
- 8
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 2
Description
Describe the bug
State::log_event (relay/src/state.rs:237-240) has 12 call sites covering most connect and disconnect failure paths, but event_log is never read by relay/src/view.rs. It is a write-only vector that also grows without limit and is never flushed to disk.
This is the root cause that makes the failures in #179 and #180 invisible.
Expected behavior
Either the log is rendered in the GUI, or it is removed and the call sites are changed to something the user can see.
Additional context
human_log writes to stderr separately, which is lost when the GUI is not started from a terminal.
Found while writing the setup documentation in #138 / #178.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with State::log_event at relay/src/state.rs:237-240, its 12 call sites, and relay/src/view.rs to trace how events are currently written and whether they can be shown in the GUI. Compare this with human_log’s stderr behavior, then determine whether rendering event_log or replacing it makes failures from #179 and #180 visible without unbounded growth.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100