Table `curl` is not using `proxy_hostname` configuration
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 23.6k
- Forks
- 2.6k
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 14
Description
Bug report
The table curl is not using the proxy_hostname configuration.
What operating system and version are you using?
Platform agnostic.
What version of osquery are you using?
5.12.2
What steps did you take to reproduce the issue?
Configure host with --proxy_hostname and query the curl table.
What did you expect to see?
I would expect curl to use the configured HTTP proxy to make its HTTPS requests.
What did you see instead?
The requests are not using the proxy configuration.
More information
Solutions I can think of:
A. The fix should be simple (moving the setting of the proxy from TLSTransport::getInternalOptions to TLSTransport::getOptions).
B. Alternative solution, considering some comments in #6034: add a column to curl table to specify whether to use the proxy or not.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the curl table implementation and the TLSTransport::getInternalOptions and TLSTransport::getOptions paths mentioned in the issue. Reproduce the query with --proxy_hostname configured, then verify that HTTPS requests from the curl table use the configured proxy; consider the stated per-query proxy alternative only if the existing behavior requires it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100