oskoperator / oskoperator/osko
Removing osko.dev/magicAlerting orphans the AlertManagerConfig
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 20
- Forks
- 3
- Avg merge
- 44m
- Merged PRs (30d)
- 7
Description
deleteUnjustifiedResource for the AlertManagerConfig sits inside the magicAlerting == "true" branch — condition at internal/controller/openslo/slo_controller.go:298, delete at :307.
Setting osko.dev/magicAlerting: "false" (or removing the annotation) on an SLO that previously had it enabled therefore skips the whole block. The owned AlertManagerConfig is never deleted and its routing config keeps being pushed to the backend.
Same failure family as the backend-transition orphan fixed in #152, different trigger. The MimirRule equivalent at :286 is unaffected — it is gated on backend capability, not on an annotation.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in internal/controller/openslo/slo_controller.go around lines 286-307 and trace how deleteUnjustifiedResource is gated by magicAlerting. Reproduce the transition from magicAlerting="true" to false or no annotation, then verify that the owned AlertManagerConfig is deleted and its routing configuration is no longer pushed to the backend.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure, observability
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100