oseledets / oseledets/ttpy

KSL function not working as it should

Open
#79 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug duplicate
Dominant language
Python
Stars
264
Forks
73
PR merge metrics
No merged PRs in 30d

Description

Hi, I know this is probably not maintained anymore but in case some wants to use the TDVP algorithm please change the file ksl.py.
The line
y0 = y0.round(1e-14)
changes the rank during TDVP and this can causes serious problems.

Raffaele

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open ksl.py and inspect the y0 = y0.round(1e-14) line within the TDVP path. Determine how that rounding changes the rank, then verify that the correction preserves the intended rank during TDVP execution.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.