osbuild / osbuild/image-builder
Ensure all pipelines that are platform-dependent include platform build packages (HMS-11197)
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 77
- Forks
- 103
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 53
Description
We should assert that all platform-dependent pipeline generators (e.g. those with a platform in their struct) call p.platform.GetBuildPackages in their getBuildPackages implementation.
lgtm but I wonder if it's worth opening an issue to go through some of the other ones, like the coreos installer etc.?
Originally posted by @croissanne in https://github.com/osbuild/image-builder/pull/2589#pullrequestreview-4914679422
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the pipeline generator structs that contain a platform and inspect each getBuildPackages implementation. Verify which implementations call p.platform.GetBuildPackages and add assertions or coverage for every platform-dependent generator. Done means all such generators are checked and the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- build-system, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100