osbuild / osbuild/image-builder
Custom partition table creation fixes and improvements
Open
@achilleas-k is already working on this.
Since Dec 10, 2024.
- Dominant language
- Go
- Stars
- 77
- Forks
- 103
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 53
Description
- We use
ef02for the BIOS boot partition on MBR/DOS. This is incorrect. The BIOS boot partition on MBR is actually not required. We may keep it for consistency (probably not the right thing to do) and, if we do, we should change the type.- Type changed to
00empty, but it's still partitioned space.- #1085
- Type changed to
- Change
ef00for ESP on DOS toef.- #1085
- Produce errors when more than 4 partitions are created on MBR PTs.
- #1085
- When a
fs_typeis missing, the error message is not helpful:invalid partitioning customizations: unknown or invalid filesystem type for mountpoint "/var"We should somehow mention that the field is calledfs_type.- #1097
- Use partition type ID constants everywhere (https://github.com/osbuild/images/pull/1085#discussion_r1878194098).
- #1099
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.