osbuild / osbuild/cloud-image-val
float() use should be replaced with version.parse()
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13
- Forks
- 26
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 11
Description
float values are not safe for comparisons, especially equality. They should not be used for version (or really, anything other than math). This codebase is already using packaging.version's parse for some of the version handling. The floats should be converted to do this as well.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for float-based version handling and inspect the existing uses of packaging.version.parse. Replace the version-related float conversions with the established parser, then run the relevant test suite to confirm comparisons still behave correctly and no version floats remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cloud
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100