ory / ory/x

File provider does not use NewKoanfFileSubKey

Open
#594 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
111
Forks
116
PR merge metrics
No merged PRs in 30d

Description

Preflight checklist
Describe the bug

I assume that in https://github.com/ory/x/blob/master/configx/provider.go NewKoanfFileSubKey should used such that it's possible to specify which node a config file should apply to.

Right now it seems to be dead code. If not maybe document how to use it?

Feature: https://github.com/ory/x/commit/c1adb0d66d226c8ea1e2f6fe1ffa3832c639b780

Reproducing the bug

Read the code :)

Relevant log output

No response

Relevant configuration

No response

Version

Keto 0.9.0

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Binary

Additional Context

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in configx/provider.go and compare the current file-provider behavior with the NewKoanfFileSubKey feature introduced in commit c1adb0d66d226c8ea1e2f6fe1ffa3832c639b780. Determine whether the subkey option is intended to affect configuration loading or only needs documentation; done means resolving that ambiguity with the corresponding code or documentation change.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.