instanceOfErrorBrowserLocationChangeRequired problem
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 178
- Forks
- 96
- Avg merge
- 6d 23h
- Merged PRs (30d)
- 3
Description
Preflight checklist
- I could not find a solution in the existing issues, docs, nor discussions.
- I agree to follow this project's Code of Conduct.
- I have read and am following this repository's Contribution Guidelines.
- I have joined the Ory Community Slack.
- I am signed up to the Ory Security Patch Newsletter.
Ory Network Project
No response
Describe the bug
export function instanceOfErrorBrowserLocationChangeRequired(value: object): value is ErrorBrowserLocationChangeRequired {
return true;
}
Why is it just true? shouldn't it check obj properties?
This is typescript client fetch
Reproducing the bug
This happens when handling errors when you need to re login in after session_refresh_required.
It always returns true so it is useless
Relevant log output
No response
Relevant configuration
No response
Version
1.3
On which operating system are you observing this issue?
Linux
In which environment are you deploying?
Docker Compose
Additional Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate instanceOfErrorBrowserLocationChangeRequired in the TypeScript client fetch and inspect the related ErrorBrowserLocationChangeRequired handling for session_refresh_required. Determine which properties distinguish this error from other values, then add a focused regression test. Done means matching errors are recognized and unrelated objects are rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100