ory / ory/sdk

instanceOfErrorBrowserLocationChangeRequired problem

Open
#383 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
PHP
Stars
178
Forks
96
Avg merge
6d 23h
Merged PRs (30d)
3

Description

Preflight checklist
Ory Network Project

No response

Describe the bug
export function instanceOfErrorBrowserLocationChangeRequired(value: object): value is ErrorBrowserLocationChangeRequired {
    return true;
}

Why is it just true? shouldn't it check obj properties?
This is typescript client fetch

Reproducing the bug

This happens when handling errors when you need to re login in after session_refresh_required.
It always returns true so it is useless

Relevant log output

No response

Relevant configuration

No response

Version

1.3

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Docker Compose

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate instanceOfErrorBrowserLocationChangeRequired in the TypeScript client fetch and inspect the related ErrorBrowserLocationChangeRequired handling for session_refresh_required. Determine which properties distinguish this error from other values, then add a focused regression test. Done means matching errors are recognized and unrelated objects are rejected.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.