ory / ory/polis

Validate nameId format

Open
#559 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
2.3k
Forks
232
PR merge metrics
No merged PRs in 30d

Description

Is your proposal related to a problem?

We require an email as the nameId format, support validation of this so that the SAML configuration is correctly set up and we can flag it if not.

Describe the solution you'd like

saml20 already supports validateNameIDFormat when parsing metadata, pass in the option when calling it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the SAML metadata parsing call that uses saml20 and read how its options are passed. Verify how validateNameIDFormat is exposed, then update the call so the email nameId requirement is enforced and confirm invalid SAML configuration is flagged.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, security
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.