allow remote authorizer 204 response as success or allowed
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3.6k
- Forks
- 415
- PR merge metrics
- No merged PRs in 30d
Description
Preflight checklist
- I could not find a solution in the existing issues, docs, nor discussions.
- I agree to follow this project's Code of Conduct.
- I have read and am following this repository's Contribution Guidelines.
- I have joined the Ory Community Slack.
- I am signed up to the Ory Security Patch Newsletter.
Ory Network Project
No response
Describe your problem
I have implemented my own authz service and it return 204 response on allowed and 403 if not, I would like remote_(json) to also accept 204 not just status 200
Describe your ideal solution
I could open a pr for this and include status code check for 204 response and do an early return for that
Workarounds or alternatives
I could add another proxy/function in front of it or change the code to return 200 instead
Version
v0.40.9
Additional Context
I think returning only status of 204 or 403 already convey the meaning when requesting to authz endpoint checking for authorization so if an authz check returns 204 it can interpret as allowed so 204 status should be accepted as success as well
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the remote_(json) authorizer's response-status handling and review how the authorization endpoint currently treats 200 and 403. Verify that 204 is accepted as allowed while 403 remains denied, then run or update the relevant tests to cover the response behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authorization
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100