ory / ory/hydra

Logout token does not contains exp claim

Open
#4,035 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
17.6k
Forks
1.6k
PR merge metrics
No merged PRs in 30d

Description

Preflight checklist
Ory Network Project

No response

Describe the bug

When validating the logout token during backchannel logout process I noticed that the exp claim is not included in token. In the OpenIDConnect specs this claim is marked as required (https://openid.net/specs/openid-connect-backchannel-1_0.html#LogoutToken). I was wondering if this is intentional or if the claim is missing.

In the source code the exp claim is not included on token creation.
https://github.com/ory/hydra/blob/36f21d0f01e962ee0155d4f64b68811f293f6651/consent/strategy_default.go#L730

Reproducing the bug

I used docker compose to setup hydra locally. Then triggered the logout process.

Relevant log output

Relevant configuration

Version

v2.2.0

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Docker Compose

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The logout token is created in consent/strategy_default.go around line 730; start there and compare its claims with the OpenID Connect Back-Channel Logout specification linked in the issue. Reproduce the backchannel logout flow in the Docker Compose setup and verify that the resulting logout token contains the required exp claim.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication, security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.